Skip to content

add API logic to promote book#405

Open
elfkuzco wants to merge 3 commits into
mainfrom
book-actions
Open

add API logic to promote book#405
elfkuzco wants to merge 3 commits into
mainfrom
book-actions

Conversation

@elfkuzco

@elfkuzco elfkuzco commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Screenshot_20260705_153920 Screenshot_20260705_152543 Screenshot_20260705_152459

Changes

  • add functions to compute actions needed to move book from current location to prod
  • add function to apply selected actions needed to move book from current location to prod

This closes #395

@elfkuzco elfkuzco self-assigned this Jul 3, 2026
@elfkuzco elfkuzco requested a review from benoit74 July 3, 2026 13:56
@elfkuzco

elfkuzco commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Even after applying actions, i'm not sure how to ignore some issues because even though books are re-processed, it sill flows through process_book. Do we want to ignore some issues like media_count, etc?

@codecov

codecov Bot commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.16216% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.12%. Comparing base (19a56da) to head (2dbe06f).

Files with missing lines Patch % Lines
backend/src/cms_backend/db/book_actions.py 86.20% 8 Missing and 8 partials ⚠️
backend/src/cms_backend/api/routes/books.py 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   80.82%   81.12%   +0.30%     
==========================================
  Files          62       63       +1     
  Lines        3494     3630     +136     
  Branches      383      418      +35     
==========================================
+ Hits         2824     2945     +121     
- Misses        553      560       +7     
- Partials      117      125       +8

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elfkuzco

elfkuzco commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

@benoit74 , I have added the UI components to show text input for the actions compted by the backend and updated PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benoit74 benoit74 Awaiting requested review from benoit74

At least 1 approving review is required to merge this pull request.

Assignees

@elfkuzco elfkuzco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement book validation operation

1 participant

@elfkuzco